CCF_100/InfiniTime
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

src: Enable unused parameter warning

Browse Source 
Fix warnings.
Some clang-formatting was necessary.
DebugPins is unused and was removed.
This commit is contained in:
Riku Isokoski
2022-12-30 23:31:31 +02:00
parent 8b0d888952
commit a3e14c012d
42 changed files with 110 additions and 168 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/displayapp/DisplayAppRecovery.cpp
View File

@@ -11,22 +11,22 @@
using namespace Pinetime::Applications;
DisplayApp::DisplayApp(Drivers::St7789& lcd,
Components::LittleVgl& lvgl,
Drivers::Cst816S& touchPanel,
Controllers::Battery& batteryController,
Components::LittleVgl& /*lvgl*/,
Drivers::Cst816S& /*touchPanel*/,
Controllers::Battery& /*batteryController*/,
Controllers::Ble& bleController,
Controllers::DateTime& dateTimeController,
Drivers::WatchdogView& watchdog,
Pinetime::Controllers::NotificationManager& notificationManager,
Pinetime::Controllers::HeartRateController& heartRateController,
Controllers::Settings& settingsController,
Pinetime::Controllers::MotorController& motorController,
Pinetime::Controllers::MotionController& motionController,
Pinetime::Controllers::TimerController& timerController,
Pinetime::Controllers::AlarmController& alarmController,
Pinetime::Controllers::BrightnessController& brightnessController,
Pinetime::Controllers::TouchHandler& touchHandler,
Pinetime::Controllers::FS& filesystem)
Controllers::DateTime& /*dateTimeController*/,
Drivers::WatchdogView& /*watchdog*/,
Pinetime::Controllers::NotificationManager& /*notificationManager*/,
Pinetime::Controllers::HeartRateController& /*heartRateController*/,
Controllers::Settings& /*settingsController*/,
Pinetime::Controllers::MotorController& /*motorController*/,
Pinetime::Controllers::MotionController& /*motionController*/,
Pinetime::Controllers::TimerController& /*timerController*/,
Pinetime::Controllers::AlarmController& /*alarmController*/,
Pinetime::Controllers::BrightnessController& /*brightnessController*/,
Pinetime::Controllers::TouchHandler& /*touchHandler*/,
Pinetime::Controllers::FS& /*filesystem*/)
: lcd {lcd}, bleController {bleController} {
}
@@ -121,5 +121,5 @@ void DisplayApp::PushMessage(Display::Messages msg) {
}
}
void DisplayApp::Register(Pinetime::System::SystemTask* systemTask) {
void DisplayApp::Register(Pinetime::System::SystemTask* /*systemTask*/) {
}

4
src/displayapp/screens/Paddle.cpp
View File

@@ -79,11 +79,11 @@ void Paddle::Refresh() {
lv_label_set_text_fmt(points, "%04d", score);
}
bool Paddle::OnTouchEvent(Pinetime::Applications::TouchEvents event) {
bool Paddle::OnTouchEvent(Pinetime::Applications::TouchEvents /*event*/) {
return true;
}
bool Paddle::OnTouchEvent(uint16_t x, uint16_t y) {
bool Paddle::OnTouchEvent(uint16_t /*x*/, uint16_t y) {
// sets the center paddle pos. (30px offset) with the the y_coordinate of the finger
// but clamp it such that the paddle never clips off screen
if (y < 31) {

4
src/displayapp/screens/Screen.h
View File

@@ -67,11 +67,11 @@ namespace Pinetime {
/** @return false if the event hasn't been handled by the app, true if it has been handled */
// Returning true will cancel lvgl tap
virtual bool OnTouchEvent(TouchEvents event) {
virtual bool OnTouchEvent(TouchEvents /*event*/) {
return false;
}
virtual bool OnTouchEvent(uint16_t x, uint16_t y) {
virtual bool OnTouchEvent(uint16_t /*x*/, uint16_t /*y*/) {
return false;
}

8
src/displayapp/screens/settings/SettingBluetooth.cpp
View File

@@ -11,12 +11,12 @@ using namespace Pinetime::Applications::Screens;
namespace {
void OnBluetoothDisabledEvent(lv_obj_t* obj, lv_event_t event) {
auto* screen = static_cast<SettingBluetooth*>(obj->user_data);
screen->OnBluetoothDisabled(obj, event);
screen->OnBluetoothDisabled(event);
}
void OnBluetoothEnabledEvent(lv_obj_t* obj, lv_event_t event) {
auto* screen = static_cast<SettingBluetooth*>(obj->user_data);
screen->OnBluetoothEnabled(obj, event);
screen->OnBluetoothEnabled(event);
}
}
@@ -75,7 +75,7 @@ SettingBluetooth::~SettingBluetooth() {
}
}
void SettingBluetooth::OnBluetoothDisabled(lv_obj_t* object, lv_event_t event) {
void SettingBluetooth::OnBluetoothDisabled(lv_event_t event) {
if (event == LV_EVENT_VALUE_CHANGED) {
lv_checkbox_set_checked(cbEnabled, false);
lv_checkbox_set_checked(cbDisabled, true);
@@ -83,7 +83,7 @@ void SettingBluetooth::OnBluetoothDisabled(lv_obj_t* object, lv_event_t event) {
}
}
void SettingBluetooth::OnBluetoothEnabled(lv_obj_t* object, lv_event_t event) {
void SettingBluetooth::OnBluetoothEnabled(lv_event_t event) {
if (event == LV_EVENT_VALUE_CHANGED) {
lv_checkbox_set_checked(cbEnabled, true);
lv_checkbox_set_checked(cbDisabled, false);

4
src/displayapp/screens/settings/SettingBluetooth.h
View File

@@ -17,8 +17,8 @@ namespace Pinetime {
SettingBluetooth(DisplayApp* app, Pinetime::Controllers::Settings& settingsController);
~SettingBluetooth() override;
void OnBluetoothEnabled(lv_obj_t* object, lv_event_t event);
void OnBluetoothDisabled(lv_obj_t* object, lv_event_t event);
void OnBluetoothEnabled(lv_event_t event);
void OnBluetoothDisabled(lv_event_t event);
private:
Controllers::Settings& settingsController;

1
src/displayapp/screens/settings/SettingSetDate.cpp
View File

@@ -100,7 +100,6 @@ void SettingSetDate::HandleButtonPress() {
dateTimeController.SetTime(yearValue,
monthValue,
dayValue,
0,
dateTimeController.Hours(),
dateTimeController.Minutes(),
dateTimeController.Seconds(),

1
src/displayapp/screens/settings/SettingSetTime.cpp
View File

@@ -99,7 +99,6 @@ void SettingSetTime::SetTime() {
dateTimeController.SetTime(dateTimeController.Year(),
static_cast<uint8_t>(dateTimeController.Month()),
dateTimeController.Day(),
static_cast<uint8_t>(dateTimeController.DayOfWeek()),
static_cast<uint8_t>(hoursValue),
static_cast<uint8_t>(minutesValue),
0,