CCF_100/citra
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Port yuzu-emu/yuzu#4700: "game_list: Eliminate redundant argument copies" (#5571)

Browse Source 
* game_list: Eliminate redundant argument copies

Several functions can be taken by const reference to avoid copies

Co-Authored-By: LC <712067+lioncash@users.noreply.github.com>

* game_list: Make game list function naming consistent

Makes the naming consistent with the rest of the functions that are
present.

Co-Authored-By: LC <712067+lioncash@users.noreply.github.com>

Co-authored-by: Lioncash <mathew1800@gmail.com>
Co-authored-by: LC <712067+lioncash@users.noreply.github.com>
This commit is contained in:
Tobias
2020-12-07 16:05:13 +01:00
committed by GitHub
parent c557b290af
commit 702af87f0d
3 changed files with 67 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/citra_qt/game_list.h
View File

@@ -55,12 +55,12 @@ public:
explicit GameList(GMainWindow* parent = nullptr);
~GameList() override;
QString getLastFilterResultItem() const;
void clearFilter();
void setFilterFocus();
void setFilterVisible(bool visibility);
void setDirectoryWatcherEnabled(bool enabled);
bool isEmpty() const;
QString GetLastFilterResultItem() const;
void ClearFilter();
void SetFilterFocus();
void SetFilterVisible(bool visibility);
void SetDirectoryWatcherEnabled(bool enabled);
bool IsEmpty() const;
void LoadCompatibilityList();
void PopulateAsync(QVector<UISettings::GameDir>& game_dirs);
@@ -77,7 +77,7 @@ public:
static const QStringList supported_file_extensions;
signals:
void GameChosen(QString game_path);
void GameChosen(const QString& game_path);
void ShouldCancelWorker();
void OpenFolderRequested(u64 program_id, GameListOpenTarget target);
void NavigateToGamedbEntryRequested(u64 program_id,
@@ -89,16 +89,16 @@ signals:
void PopulatingCompleted();
private slots:
void onItemExpanded(const QModelIndex& item);
void onTextChanged(const QString& new_text);
void onFilterCloseClicked();
void onUpdateThemedIcons();
void OnItemExpanded(const QModelIndex& item);
void OnTextChanged(const QString& new_text);
void OnFilterCloseClicked();
void OnUpdateThemedIcons();
private:
void AddDirEntry(GameListDir* entry_items);
void AddEntry(const QList<QStandardItem*>& entry_items, GameListDir* parent);
void ValidateEntry(const QModelIndex& item);
void DonePopulating(QStringList watch_list);
void DonePopulating(const QStringList& watch_list);
void PopupContextMenu(const QPoint& menu_location);
void AddGamePopup(QMenu& context_menu, const QString& path, u64 program_id, u64 extdata_id);