HLE: CaptureManager: SaveScreenShot: properly handle screenshot image data (#18)

no way this was working before, and if it did, just pure luck, unsafe blind copy of bytes as is and zero checks.

i only tested tomodachi, but should fix all games that were crashing on saving screenshots

the crash was happening because the screenshot buffer was bigger than the bitmap buffer, so marshall.copy() was raising an unhandhled expection crashing the emu.

on top of this, because the data was just copied as is, the result image was garbled.

[fixes #304](https://github.com/Ryubing/Issues/issues/304)

Reviewed-on: https://git.ryujinx.app/projects/Ryubing/pulls/18

.forgejo/labeler.yml

@@ -10,6 +10,10 @@ gpu:
 - changed-files:
   - any-glob-to-any-file: ['src/Ryujinx.Graphics.*/**', 'src/Spv.Generator/**', 'src/Ryujinx.ShaderTools/**']
 
+input:
+- changed-files:
+  - any-glob-to-any-file: ['src/Ryujinx.Input*/**', 'src/Ryujinx/UI/Views/Input/**']
+
 'graphics-backend:opengl':
 - changed-files:
   - any-glob-to-any-file: 'src/Ryujinx.Graphics.OpenGL/**'
@@ -18,17 +22,17 @@ gpu:
 - changed-files:
   - any-glob-to-any-file: ['src/Ryujinx.Graphics.Vulkan/**', 'src/Spv.Generator/**']
 
-'graphics-backend:metal':
-  - changed-files:
-      - any-glob-to-any-file: ['src/Ryujinx.Graphics.Metal/**', 'src/Ryujinx.Graphics.Metal.SharpMetalExtensions/**']
-
 gui:
 - changed-files:
-  - any-glob-to-any-file: ['src/Ryujinx/**', 'src/Ryujinx.UI.Common/**', 'src/Ryujinx.UI.LocaleGenerator/**']
+  - any-glob-to-any-file: ['src/Ryujinx/**', 'src/Ryujinx.UI.LocaleGenerator/**']
 
-horizon:
+'horizon/hle':
 - changed-files:
-  - any-glob-to-any-file: ['src/Ryujinx.HLE/**', 'src/Ryujinx.Horizon/**']
+  - any-glob-to-any-file: ['src/Ryujinx.HLE/**', 'src/Ryujinx.HLE.Generators/**', 'src/Ryujinx.Horizon/**']
+
+i18n:
+- changed-files:
+  - any-glob-to-any-file: ['assets/**/*.json', 'src/Ryujinx.UI.LocaleGenerator/**']
 
 kernel:
 - changed-files:
@@ -44,4 +48,4 @@ documentation:
 
 ldn:
 - changed-files:
-  - any-glob-to-any-file: 'src/Ryujinx.HLE/HOS/Services/Ldn/**'
+  - any-glob-to-any-file: ['src/Ryujinx.HLE/HOS/Services/Ldn/**', 'src/Ryujinx/UI/Windows/LdnGamesListWindow.*', 'src/Ryujinx/UI/ViewModels/LdnGamesListViewModel.cs']

.forgejo/workflows/pr_triage.yml

@@ -18,7 +18,7 @@ jobs:
            ref: master
 
       - name: Update labels based on changes
-        uses: actions/labeler@v5
+        uses: actions/labeler@v6
         with:
           repo-token: ${{ secrets.LABELER_TOKEN }}
           configuration-path: .forgejo/labeler.yml

assets/Locales/RenderDoc.json

@@ -22,7 +22,7 @@
         "tr_TR": "",
         "uk_UA": "",
         "zh_CN": "启动 RenderDoc 帧捕获",
-        "zh_TW": ""
+        "zh_TW": "啟動 RenderDoc 畫格擷取"
       }
     },
     {
@@ -47,7 +47,7 @@
         "tr_TR": "",
         "uk_UA": "",
         "zh_CN": "结束 RenderDoc 帧捕获",
-        "zh_TW": ""
+        "zh_TW": "停止 RenderDoc 畫格擷取"
       }
     },
     {
@@ -72,7 +72,7 @@
         "tr_TR": "",
         "uk_UA": "",
         "zh_CN": "丢弃 RenderDoc 帧捕获",
-        "zh_TW": ""
+        "zh_TW": "捨棄 RenderDoc 畫格擷取"
       }
     },
     {
@@ -97,7 +97,7 @@
         "tr_TR": "",
         "uk_UA": "",
         "zh_CN": "结束当前正在进行的 RenderDoc 帧捕获，并立即丢弃其结果。",
-        "zh_TW": ""
+        "zh_TW": "停止正在執行的 RenderDoc 畫格擷取，且立即捨棄其結果。"
       }
     }
   ]

assets/Locales/Root.json

@@ -582,8 +582,8 @@
         "de_DE": "",
         "el_GR": "",
         "en_US": "Restart Emulation",
-        "es_ES": "",
-        "fr_FR": "",
+        "es_ES": "Reiniciar Emulación",
+        "fr_FR": "Redémarrer l'Émulation",
         "he_IL": "",
         "it_IT": "",
         "ja_JP": "",
@@ -597,7 +597,7 @@
         "tr_TR": "",
         "uk_UA": "",
         "zh_CN": "",
-        "zh_TW": ""
+        "zh_TW": "重新啟動模擬"
       }
     },
     {
@@ -11332,8 +11332,8 @@
         "de_DE": "Speichern",
         "el_GR": "",
         "en_US": "Save",
-        "es_ES": "",
-        "fr_FR": "",
+        "es_ES": "Guardar",
+        "fr_FR": "Sauvegarder",
         "he_IL": "",
         "it_IT": "",
         "ja_JP": "",
@@ -11347,7 +11347,7 @@
         "tr_TR": "",
         "uk_UA": "",
         "zh_CN": "",
-        "zh_TW": ""
+        "zh_TW": "儲存"
       }
     },
     {

src/Ryujinx.HLE/HOS/Services/Caps/CaptureManager.cs

@@ -118,8 +118,11 @@ namespace Ryujinx.HLE.HOS.Services.Caps
                 }
 
                 // NOTE: The saved JPEG file doesn't have the limitation in the extra EXIF data.
-                using SKBitmap bitmap = new(new SKImageInfo(1280, 720, SKColorType.Rgba8888));
-                Marshal.Copy(screenshotData, 0, bitmap.GetPixels(), screenshotData.Length);
+                using SKBitmap bitmap = new(new SKImageInfo(1280, 720, SKColorType.Rgba8888, SKAlphaType.Premul));
+                int dataLen = screenshotData.Length > bitmap.ByteCount ? bitmap.ByteCount : screenshotData.Length;
+
+                Marshal.Copy(screenshotData, 0, bitmap.GetPixels(), dataLen);
+
                 using SKData data = bitmap.Encode(SKEncodedImageFormat.Jpeg, 80);
                 using FileStream file = File.OpenWrite(filePath);
                 data.SaveTo(file);