mirror of
				https://git.suyu.dev/suyu/suyu
				synced 2025-11-04 00:49:02 -06:00 
			
		
		
		
	"AudioRenderer" thread should have a unique name
Creating multiple "AudioRenderer" threads cause the previous thread to be overwritten. The thread will name be renamed to AudioRenderer-InstanceX, where X is the current instance number.
This commit is contained in:
		@@ -25,7 +25,7 @@ namespace Service::Audio {
 | 
			
		||||
 | 
			
		||||
class IAudioRenderer final : public ServiceFramework<IAudioRenderer> {
 | 
			
		||||
public:
 | 
			
		||||
    explicit IAudioRenderer(AudioCore::AudioRendererParameter audren_params)
 | 
			
		||||
    explicit IAudioRenderer(AudioCore::AudioRendererParameter audren_params, const std::size_t instance_number)
 | 
			
		||||
        : ServiceFramework("IAudioRenderer") {
 | 
			
		||||
        // clang-format off
 | 
			
		||||
        static const FunctionInfo functions[] = {
 | 
			
		||||
@@ -48,8 +48,7 @@ public:
 | 
			
		||||
        auto& system = Core::System::GetInstance();
 | 
			
		||||
        system_event = Kernel::WritableEvent::CreateEventPair(
 | 
			
		||||
            system.Kernel(), Kernel::ResetType::Manual, "IAudioRenderer:SystemEvent");
 | 
			
		||||
        renderer = std::make_unique<AudioCore::AudioRenderer>(system.CoreTiming(), audren_params,
 | 
			
		||||
                                                              system_event.writable);
 | 
			
		||||
        renderer = std::make_unique<AudioCore::AudioRenderer>(system.CoreTiming(), audren_params, system_event.writable, instance_number);
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
private:
 | 
			
		||||
@@ -607,7 +606,7 @@ void AudRenU::OpenAudioRendererImpl(Kernel::HLERequestContext& ctx) {
 | 
			
		||||
    IPC::ResponseBuilder rb{ctx, 2, 0, 1};
 | 
			
		||||
 | 
			
		||||
    rb.Push(RESULT_SUCCESS);
 | 
			
		||||
    rb.PushIpcInterface<IAudioRenderer>(params);
 | 
			
		||||
    rb.PushIpcInterface<IAudioRenderer>(params, audren_instance_count++);
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
bool AudRenU::IsFeatureSupported(AudioFeatures feature, u32_le revision) const {
 | 
			
		||||
 
 | 
			
		||||
@@ -33,6 +33,7 @@ private:
 | 
			
		||||
    };
 | 
			
		||||
 | 
			
		||||
    bool IsFeatureSupported(AudioFeatures feature, u32_le revision) const;
 | 
			
		||||
    std::size_t audren_instance_count = 0;
 | 
			
		||||
};
 | 
			
		||||
 | 
			
		||||
} // namespace Service::Audio
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user