mirror of
				https://git.suyu.dev/suyu/suyu
				synced 2025-11-04 08:59:03 -06:00 
			
		
		
		
	Merge pull request #3978 from ReinUsesLisp/write-rz
shader_decompiler: Visit source nodes even when they assign to RZ
This commit is contained in:
		@@ -1538,7 +1538,9 @@ private:
 | 
			
		||||
        Expression target;
 | 
			
		||||
        if (const auto gpr = std::get_if<GprNode>(&*dest)) {
 | 
			
		||||
            if (gpr->GetIndex() == Register::ZeroIndex) {
 | 
			
		||||
                // Writing to Register::ZeroIndex is a no op
 | 
			
		||||
                // Writing to Register::ZeroIndex is a no op but we still have to visit the source
 | 
			
		||||
                // as it might have side effects.
 | 
			
		||||
                code.AddLine("{};", Visit(src).GetCode());
 | 
			
		||||
                return {};
 | 
			
		||||
            }
 | 
			
		||||
            target = {GetRegister(gpr->GetIndex()), Type::Float};
 | 
			
		||||
 
 | 
			
		||||
@@ -1081,8 +1081,7 @@ private:
 | 
			
		||||
 | 
			
		||||
    void VisitBasicBlock(const NodeBlock& bb) {
 | 
			
		||||
        for (const auto& node : bb) {
 | 
			
		||||
            [[maybe_unused]] const Type type = Visit(node).type;
 | 
			
		||||
            ASSERT(type == Type::Void);
 | 
			
		||||
            Visit(node);
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
@@ -1372,7 +1371,9 @@ private:
 | 
			
		||||
        Expression target{};
 | 
			
		||||
        if (const auto gpr = std::get_if<GprNode>(&*dest)) {
 | 
			
		||||
            if (gpr->GetIndex() == Register::ZeroIndex) {
 | 
			
		||||
                // Writing to Register::ZeroIndex is a no op
 | 
			
		||||
                // Writing to Register::ZeroIndex is a no op but we still have to visit its source
 | 
			
		||||
                // because it might have side effects.
 | 
			
		||||
                Visit(src);
 | 
			
		||||
                return {};
 | 
			
		||||
            }
 | 
			
		||||
            target = {registers.at(gpr->GetIndex()), Type::Float};
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user