mirror of
				https://git.suyu.dev/suyu/suyu
				synced 2025-10-31 07:59:02 -05:00 
			
		
		
		
	am: Return StubApplet instead of nullptr when AppletId not found
This commit is contained in:
		| @@ -6,8 +6,6 @@ | ||||
| #include <cinttypes> | ||||
| #include <cstring> | ||||
| #include <stack> | ||||
| #include "applets/applets.h" | ||||
| #include "applets/software_keyboard.h" | ||||
| #include "audio_core/audio_renderer.h" | ||||
| #include "core/core.h" | ||||
| #include "core/hle/ipc_helpers.h" | ||||
| @@ -18,6 +16,9 @@ | ||||
| #include "core/hle/service/am/am.h" | ||||
| #include "core/hle/service/am/applet_ae.h" | ||||
| #include "core/hle/service/am/applet_oe.h" | ||||
| #include "core/hle/service/am/applets/applets.h" | ||||
| #include "core/hle/service/am/applets/software_keyboard.h" | ||||
| #include "core/hle/service/am/applets/stub_applet.h" | ||||
| #include "core/hle/service/am/idle.h" | ||||
| #include "core/hle/service/am/omm.h" | ||||
| #include "core/hle/service/am/spsm.h" | ||||
| @@ -761,8 +762,9 @@ static std::shared_ptr<Applets::Applet> GetAppletFromId(AppletId id) { | ||||
|     case AppletId::SoftwareKeyboard: | ||||
|         return std::make_shared<Applets::SoftwareKeyboard>(); | ||||
|     default: | ||||
|         UNREACHABLE_MSG("Unimplemented AppletId [{:08X}]!", static_cast<u32>(id)); | ||||
|         return nullptr; | ||||
|         LOG_ERROR(Service_AM, "Unimplemented AppletId [{:08X}]! -- Falling back to stub!", | ||||
|                   static_cast<u32>(id)); | ||||
|         return std::make_shared<Applets::StubApplet>(); | ||||
|     } | ||||
| } | ||||
|  | ||||
|   | ||||
| @@ -2,7 +2,12 @@ | ||||
| // Licensed under GPLv2 or any later version | ||||
| // Refer to the license.txt file included. | ||||
|  | ||||
| #include <string> | ||||
|  | ||||
| #include "common/hex_util.h" | ||||
| #include "common/logging/log.h" | ||||
| #include "core/hle/result.h" | ||||
| #include "core/hle/service/am/am.h" | ||||
| #include "core/hle/service/am/applets/stub_applet.h" | ||||
|  | ||||
| namespace Service::AM::Applets { | ||||
|   | ||||
| @@ -4,13 +4,6 @@ | ||||
|  | ||||
| #pragma once | ||||
|  | ||||
| #include <array> | ||||
| #include <string> | ||||
| #include <vector> | ||||
|  | ||||
| #include "common/common_funcs.h" | ||||
| #include "common/swap.h" | ||||
| #include "core/hle/service/am/am.h" | ||||
| #include "core/hle/service/am/applets/applets.h" | ||||
|  | ||||
| namespace Service::AM::Applets { | ||||
|   | ||||
		Reference in New Issue
	
	Block a user
	 Zach Hilman
					Zach Hilman