Lioncash 
							
						 
					 
					
						
						
							
						
						6b2bece81f 
					 
					
						
						
							
							kernel/wait_object: Make GetHighestPriorityReadyThread() a const member function  
						
						 
						
						... 
						
						
						
						This doesn't actually modify internal state of a wait object, so it can
be const qualified. 
						
						
					 
					
						2019-04-17 06:44:34 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
						
						9186f76b07 
					 
					
						
						
							
							Merge pull request  #2382  from lioncash/table  
						
						 
						
						... 
						
						
						
						service: Update service function tables 
						
						
					 
					
						2019-04-15 21:46:15 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
						
						fc64156533 
					 
					
						
						
							
							Merge pull request  #2393  from lioncash/svc  
						
						 
						
						... 
						
						
						
						kernel/svc: Implement svcMapProcessCodeMemory/svcUnmapProcessCodeMemory 
						
						
					 
					
						2019-04-15 21:43:56 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
							
						
						e3566e6c1d 
					 
					
						
						
							
							kernel/thread: Remove BoostPriority()  
						
						 
						
						... 
						
						
						
						This is a holdover from Citra that currently remains unused, so it can
be removed from the Thread interface. 
						
						
					 
					
						2019-04-15 06:59:19 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
						
						1f4dfb3998 
					 
					
						
						
							
							Merge pull request  #2378  from lioncash/ro  
						
						 
						
						... 
						
						
						
						ldr: Minor amendments to IPC-related parameters 
						
						
					 
					
						2019-04-13 22:16:10 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
						
						6088898b02 
					 
					
						
						
							
							Merge pull request  #2357  from zarroboogs/force-30fps-mode  
						
						 
						
						... 
						
						
						
						Add a toggle to force 30FPS mode 
						
						
					 
					
						2019-04-13 22:14:04 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
						
						a788c861bd 
					 
					
						
						
							
							Merge pull request  #2381  from lioncash/fs  
						
						 
						
						... 
						
						
						
						fsp_srv: Minor cleanup related changes 
						
						
					 
					
						2019-04-13 22:09:58 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
						
						065f83c6c3 
					 
					
						
						
							
							Merge pull request  #2017  from jroweboy/glwidget  
						
						 
						
						... 
						
						
						
						Frontend: Migrate to QOpenGLWindow and support shared contexts 
						
						
					 
					
						2019-04-13 22:08:40 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
							
						
						4d293bb5cb 
					 
					
						
						
							
							kernel/svc: Implement svcUnmapProcessCodeMemory  
						
						 
						
						... 
						
						
						
						Essentially performs the inverse of svcMapProcessCodeMemory. This unmaps
the aliasing region first, then restores the general traits of the
aliased memory.
What this entails, is:
- Restoring Read/Write permissions to the VMA.
- Restoring its memory state to reflect it as a general heap memory region.
- Clearing the memory attributes on the region. 
						
						
					 
					
						2019-04-12 21:56:03 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
							
						
						76a2465655 
					 
					
						
						
							
							kernel/svc: Implement svcMapProcessCodeMemory  
						
						 
						
						... 
						
						
						
						This is utilized for mapping code modules into memory. Notably, the
ldr service would call this in order to map objects into memory. 
						
						
					 
					
						2019-04-12 21:55:50 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
						
						83a2fb3c3a 
					 
					
						
						
							
							Merge pull request  #2360  from lioncash/svc-global  
						
						 
						
						... 
						
						
						
						kernel/svc: Deglobalize the supervisor call handlers 
						
						
					 
					
						2019-04-11 21:50:05 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
						
						e2f2155dab 
					 
					
						
						
							
							Merge pull request  #2388  from lioncash/constexpr  
						
						 
						
						... 
						
						
						
						kernel: Make handle type declarations constexpr 
						
						
					 
					
						2019-04-11 21:49:45 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
							
						
						6300ccbc3c 
					 
					
						
						
							
							kernel: Make handle type declarations constexpr  
						
						 
						
						... 
						
						
						
						Some objects declare their handle type as const, while others declare it
as constexpr. This makes the const ones constexpr for consistency, and
prevent unexpected compilation errors if these happen to be attempted to be
used within a constexpr context. 
						
						
					 
					
						2019-04-11 16:34:53 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
							
						
						ca96dc4676 
					 
					
						
						
							
							service: Update service function tables  
						
						 
						
						... 
						
						
						
						Updates function tables based off information from SwitchBrew. 
						
						
					 
					
						2019-04-11 02:47:00 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
							
						
						dae2449880 
					 
					
						
						
							
							ldr: Mark IsValidNROHash() as a const member function  
						
						 
						
						... 
						
						
						
						This doesn't modify instance state, so it can be made const. 
						
						
					 
					
						2019-04-10 15:57:02 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
							
						
						0032cf3818 
					 
					
						
						
							
							ldr: Amend parameters for LoadNro/UnloadNro LoadNrr/UnloadNrr  
						
						 
						
						... 
						
						
						
						The initial two words indicate a process ID. Also UnloadNro only
specifies one address, not two. 
						
						
					 
					
						2019-04-10 15:56:43 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
							
						
						8676832064 
					 
					
						
						
							
							fsp_srv: Remove unnecessary parameter popping in IDirectory's Read()  
						
						 
						
						... 
						
						
						
						IDirectory's Read() function doesn't take any input parameters. It only
uses the output parameters that we already provide. 
						
						
					 
					
						2019-04-10 13:04:08 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
							
						
						fc436bb09b 
					 
					
						
						
							
							fsp_srv: Log out option values in IFile's Read and Write functions  
						
						 
						
						... 
						
						
						
						These indicate options that alter how a read/write is performed.
Currently we don't need to handle these, as the only one that seems to
be used is for writes, but all the custom options ever seem to do is
immediate flushing, which we already do by default. 
						
						
					 
					
						2019-04-10 13:01:52 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
							
						
						08d507a196 
					 
					
						
						
							
							kernel/server_session: Remove obsolete TODOs  
						
						 
						
						... 
						
						
						
						These are holdovers from Citra. 
						
						
					 
					
						2019-04-09 23:34:49 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
						
						61f63bb994 
					 
					
						
						
							
							Merge pull request  #1957  from DarkLordZach/title-provider  
						
						 
						
						... 
						
						
						
						file_sys: Provide generic interface for accessing game data 
						
						
					 
					
						2019-04-09 19:16:37 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
							
						
						2abf979c35 
					 
					
						
						
							
							kernel/process: Set page table when page table resizes occur.  
						
						 
						
						... 
						
						
						
						We need to ensure dynarmic gets a valid pointer if the page table is
resized (the relevant pointers would be invalidated in this scenario).
In this scenario, the page table can be resized depending on what kind
of address space is specified within the NPDM metadata (if it's
present). 
						
						
					 
					
						2019-04-09 13:00:56 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								zarroboogs 
							
						 
					 
					
						
						
							
						
						be6466d5c0 
					 
					
						
						
							
							added a toggle to force 30fps mode  
						
						 
						
						
						
						
					 
					
						2019-04-09 02:14:03 +03:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
							
						
						b117ca5fce 
					 
					
						
						
							
							kernel/svc: Deglobalize the supervisor call handlers  
						
						 
						
						... 
						
						
						
						Adjusts the interface of the wrappers to take a system reference, which
allows accessing a system instance without using the global accessors.
This also allows getting rid of all global accessors within the
supervisor call handling code. While this does make the wrappers
themselves slightly more noisy, this will be further cleaned up in a
follow-up. This eliminates the global system accessors in the current
code while preserving the existing interface. 
						
						
					 
					
						2019-04-07 20:30:05 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
						
						3c1ce290d0 
					 
					
						
						
							
							Merge pull request  #2361  from lioncash/pagetable  
						
						 
						
						... 
						
						
						
						core/memory: Minor simplifications to page table management 
						
						
					 
					
						2019-04-07 17:50:31 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
						
						52ad5fa0e8 
					 
					
						
						
							
							Merge pull request  #2356  from lioncash/pair  
						
						 
						
						... 
						
						
						
						kernel/{server_port, server_session}: Return pairs instead of tuples from pair creation functions 
						
						
					 
					
						2019-04-07 17:48:00 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
							
						
						36a1e6a982 
					 
					
						
						
							
							core/memory: Remove unused enum constants  
						
						 
						
						... 
						
						
						
						These are holdovers from Citra and can be removed. 
						
						
					 
					
						2019-04-07 03:04:55 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
							
						
						abae7577d2 
					 
					
						
						
							
							core/memory: Remove GetCurrentPageTable()  
						
						 
						
						... 
						
						
						
						Now that nothing actually touches the internal page table aside from the
memory subsystem itself, we can remove the accessor to it. 
						
						
					 
					
						2019-04-07 02:47:37 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
							
						
						a6a82bb004 
					 
					
						
						
							
							arm/arm_dynarmic: Remove unnecessary current_page_table member  
						
						 
						
						... 
						
						
						
						Given the page table will always be guaranteed to be that of whatever
the current process is, we no longer need to keep this around. 
						
						
					 
					
						2019-04-07 02:43:51 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
							
						
						e779686a76 
					 
					
						
						
							
							kernel: Handle page table switching within MakeCurrentProcess()  
						
						 
						
						... 
						
						
						
						Centralizes the page table switching to one spot, rather than making
calling code deal with it everywhere. 
						
						
					 
					
						2019-04-07 01:12:54 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
							
						
						7a7ffa602d 
					 
					
						
						
							
							kernel/server_session: Return a std::pair from CreateSessionPair()  
						
						 
						
						... 
						
						
						
						Keeps the return type consistent with the function name. While we're at
it, we can also reduce the amount of boilerplate involved with handling
these by using structured bindings. 
						
						
					 
					
						2019-04-06 01:42:03 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
							
						
						04d265562f 
					 
					
						
						
							
							kernel/server_port: Return a std::pair from CreatePortPair()  
						
						 
						
						... 
						
						
						
						Returns the same type that the function name describes. 
						
						
					 
					
						2019-04-06 01:36:53 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
						
						7d1c0fd1ad 
					 
					
						
						
							
							Merge pull request  #2325  from lioncash/name  
						
						 
						
						... 
						
						
						
						kernel/server_session: Provide a GetName() override 
						
						
					 
					
						2019-04-05 23:48:13 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
						
						54c7e8e40e 
					 
					
						
						
							
							Merge pull request  #2240  from FearlessTobi/port-4651  
						
						 
						
						... 
						
						
						
						Port citra-emu/citra#4651 : "gdbstub: Fix some bugs in IsMemoryBreak() and ServeBreak. Add workaround to let watchpoints break into GDB." 
						
						
					 
					
						2019-04-05 23:46:37 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
						
						00207cc965 
					 
					
						
						
							
							Merge pull request  #2340  from lioncash/view  
						
						 
						
						... 
						
						
						
						file_sys/fsmitm_romfsbuild: Utilize a string_view in romfs_calc_path_hash 
						
						
					 
					
						2019-04-05 23:40:16 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
						
						e86b26cd2b 
					 
					
						
						
							
							Merge pull request  #2334  from lioncash/override  
						
						 
						
						... 
						
						
						
						core: Add missing override specifiers where applicable 
						
						
					 
					
						2019-04-05 23:39:52 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
						
						23d3cd7604 
					 
					
						
						
							
							Merge pull request  #2341  from lioncash/compare  
						
						 
						
						... 
						
						
						
						file_sys/nca_metadata: Remove unnecessary comparison operators for TitleType 
						
						
					 
					
						2019-04-05 23:38:37 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
						
						d6cddffb78 
					 
					
						
						
							
							Merge pull request  #2339  from lioncash/rank  
						
						 
						
						... 
						
						
						
						service/fsp_srv: Update SaveDataInfo and SaveDataDescriptor structs 
						
						
					 
					
						2019-04-05 23:36:46 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
						
						b8fbd125e6 
					 
					
						
						
							
							Merge pull request  #2343  from lioncash/todo  
						
						 
						
						... 
						
						
						
						file_sys/program_metadata: Remove obsolete TODOs 
						
						
					 
					
						2019-04-05 23:35:54 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
						
						854ac468b9 
					 
					
						
						
							
							Merge pull request  #2329  from lioncash/sanitize  
						
						 
						
						... 
						
						
						
						kernel/svc: Properly sanitize mutex address in WaitProcessWideKeyAtomic 
						
						
					 
					
						2019-04-05 23:35:06 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
						
						150a3c0890 
					 
					
						
						
							
							Merge pull request  #2344  from lioncash/result  
						
						 
						
						... 
						
						
						
						hle/result: Remove unnecessary bitfield entry for ResultCode 
						
						
					 
					
						2019-04-05 23:34:42 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
							
						
						5dfcf7cf26 
					 
					
						
						
							
							hle/result: Remove unnecessary bitfield entry for ResultCode  
						
						 
						
						... 
						
						
						
						This is a hold over from the 3DS error codes in Citra. 
						
						
					 
					
						2019-04-05 16:34:34 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
							
						
						37b23efece 
					 
					
						
						
							
							file_sys/program_metadata: Remove obsolete TODOs  
						
						 
						
						... 
						
						
						
						BitField has been trivially copyable since
e99a148628 , so we can eliminate these
TODO comments and use ReadObject() directly instead of memcpying the
data. 
						
						
					 
					
						2019-04-05 15:57:47 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
							
						
						a1868286b0 
					 
					
						
						
							
							file_sys/nca_metadata: Remove unnecessary comparison operators for TitleType  
						
						 
						
						... 
						
						
						
						enum class elements from the same enum can already be compared against
one another without the need for explicitly defined comparison
operators. 
						
						
					 
					
						2019-04-05 15:20:07 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
							
						
						28e36de56f 
					 
					
						
						
							
							file_sys/fsmitm_romfsbuild: Utilize a string_view in romfs_calc_path_hash()  
						
						 
						
						... 
						
						
						
						The given string instance doesn't need to be copied entirely, we can
just use a view instead. 
						
						
					 
					
						2019-04-05 15:12:20 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
							
						
						c05c8a7a06 
					 
					
						
						
							
							service/fsp_srv: Don't pass SaveDataDescriptor instances by value.  
						
						 
						
						... 
						
						
						
						Passing around a 64 byte data struct by value is kind of wasteful,
instead pass a reference to the struct. 
						
						
					 
					
						2019-04-05 11:04:01 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
							
						
						d0ed3ff4b7 
					 
					
						
						
							
							service/fsp_srv: Remove unnecessary unknown member in OpenSaveDataFileSystem  
						
						 
						
						... 
						
						
						
						The unknown member here is actually padding due to being passed as a
struct. We can do the same, and remove the need to pop a padding word. 
						
						
					 
					
						2019-04-05 11:04:01 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
							
						
						d9ee58a3b5 
					 
					
						
						
							
							service/fsp_srv: Update SaveDataInfo and SaveDataDescriptor structs  
						
						 
						
						... 
						
						
						
						I realized that I updated the documentation on SwitchBrew a while ago,
but never actually updated the structs within yuzu. 
						
						
					 
					
						2019-04-05 11:03:53 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
						
						d6b7195192 
					 
					
						
						
							
							Merge pull request  #2338  from lioncash/fs  
						
						 
						
						... 
						
						
						
						filesystem: Use a std::string_view in OpenFile() 
						
						
					 
					
						2019-04-05 10:52:54 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
						
						7c1af3aa10 
					 
					
						
						
							
							Merge pull request  #2292  from lioncash/nacp  
						
						 
						
						... 
						
						
						
						file_sys/control_metadata: Amend naming of members 
						
						
					 
					
						2019-04-04 22:37:42 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
							
						
						15e0c4c4ec 
					 
					
						
						
							
							filesystem: Use a std::string_view in OpenFile()  
						
						 
						
						... 
						
						
						
						Rather than make a full copy of the path, we can just use a string view
and truncate the viewed portion of the string instead of creating a totally
new truncated string. 
						
						
					 
					
						2019-04-04 20:59:00 -04:00