mirror of
				https://git.suyu.dev/suyu/suyu
				synced 2025-11-03 16:39:01 -06:00 
			
		
		
		
	Revert "Merge pull request #7395 from Morph1984/resolve-comments"
This reverts commitd20f91da11, reversing changes made to5082712b4e.
This commit is contained in:
		@@ -751,9 +751,8 @@ void BlitImageHelper::ConvertColorToDepthPipeline(vk::Pipeline& pipeline, VkRend
 | 
			
		||||
    });
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
void BlitImageHelper::ConvertPipelineEx(vk::Pipeline& pipeline, VkRenderPass renderpass,
 | 
			
		||||
                                        vk::ShaderModule& module, bool is_target_depth,
 | 
			
		||||
                                        bool single_texture) {
 | 
			
		||||
void BlitImageHelper::ConvertPipelineColorTargetEx(vk::Pipeline& pipeline, VkRenderPass renderpass,
 | 
			
		||||
                                                   vk::ShaderModule& module, bool single_texture) {
 | 
			
		||||
    if (pipeline) {
 | 
			
		||||
        return;
 | 
			
		||||
    }
 | 
			
		||||
@@ -770,7 +769,7 @@ void BlitImageHelper::ConvertPipelineEx(vk::Pipeline& pipeline, VkRenderPass ren
 | 
			
		||||
        .pViewportState = &PIPELINE_VIEWPORT_STATE_CREATE_INFO,
 | 
			
		||||
        .pRasterizationState = &PIPELINE_RASTERIZATION_STATE_CREATE_INFO,
 | 
			
		||||
        .pMultisampleState = &PIPELINE_MULTISAMPLE_STATE_CREATE_INFO,
 | 
			
		||||
        .pDepthStencilState = is_target_depth ? &PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO : nullptr,
 | 
			
		||||
        .pDepthStencilState = nullptr,
 | 
			
		||||
        .pColorBlendState = &PIPELINE_COLOR_BLEND_STATE_GENERIC_CREATE_INFO,
 | 
			
		||||
        .pDynamicState = &PIPELINE_DYNAMIC_STATE_CREATE_INFO,
 | 
			
		||||
        .layout = single_texture ? *one_texture_pipeline_layout : *two_textures_pipeline_layout,
 | 
			
		||||
@@ -781,14 +780,33 @@ void BlitImageHelper::ConvertPipelineEx(vk::Pipeline& pipeline, VkRenderPass ren
 | 
			
		||||
    });
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
void BlitImageHelper::ConvertPipelineColorTargetEx(vk::Pipeline& pipeline, VkRenderPass renderpass,
 | 
			
		||||
                                                   vk::ShaderModule& module, bool single_texture) {
 | 
			
		||||
    ConvertPipelineEx(pipeline, renderpass, module, false, single_texture);
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
void BlitImageHelper::ConvertPipelineDepthTargetEx(vk::Pipeline& pipeline, VkRenderPass renderpass,
 | 
			
		||||
                                                   vk::ShaderModule& module, bool single_texture) {
 | 
			
		||||
    ConvertPipelineEx(pipeline, renderpass, module, true, single_texture);
 | 
			
		||||
    if (pipeline) {
 | 
			
		||||
        return;
 | 
			
		||||
    }
 | 
			
		||||
    const std::array stages = MakeStages(*full_screen_vert, *module);
 | 
			
		||||
    pipeline = device.GetLogical().CreateGraphicsPipeline({
 | 
			
		||||
        .sType = VK_STRUCTURE_TYPE_GRAPHICS_PIPELINE_CREATE_INFO,
 | 
			
		||||
        .pNext = nullptr,
 | 
			
		||||
        .flags = 0,
 | 
			
		||||
        .stageCount = static_cast<u32>(stages.size()),
 | 
			
		||||
        .pStages = stages.data(),
 | 
			
		||||
        .pVertexInputState = &PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO,
 | 
			
		||||
        .pInputAssemblyState = &PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO,
 | 
			
		||||
        .pTessellationState = nullptr,
 | 
			
		||||
        .pViewportState = &PIPELINE_VIEWPORT_STATE_CREATE_INFO,
 | 
			
		||||
        .pRasterizationState = &PIPELINE_RASTERIZATION_STATE_CREATE_INFO,
 | 
			
		||||
        .pMultisampleState = &PIPELINE_MULTISAMPLE_STATE_CREATE_INFO,
 | 
			
		||||
        .pDepthStencilState = &PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO,
 | 
			
		||||
        .pColorBlendState = &PIPELINE_COLOR_BLEND_STATE_EMPTY_CREATE_INFO,
 | 
			
		||||
        .pDynamicState = &PIPELINE_DYNAMIC_STATE_CREATE_INFO,
 | 
			
		||||
        .layout = single_texture ? *one_texture_pipeline_layout : *two_textures_pipeline_layout,
 | 
			
		||||
        .renderPass = renderpass,
 | 
			
		||||
        .subpass = 0,
 | 
			
		||||
        .basePipelineHandle = VK_NULL_HANDLE,
 | 
			
		||||
        .basePipelineIndex = 0,
 | 
			
		||||
    });
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
} // namespace Vulkan
 | 
			
		||||
 
 | 
			
		||||
@@ -80,9 +80,6 @@ private:
 | 
			
		||||
 | 
			
		||||
    void ConvertColorToDepthPipeline(vk::Pipeline& pipeline, VkRenderPass renderpass);
 | 
			
		||||
 | 
			
		||||
    void ConvertPipelineEx(vk::Pipeline& pipeline, VkRenderPass renderpass,
 | 
			
		||||
                           vk::ShaderModule& module, bool is_target_depth, bool single_texture);
 | 
			
		||||
 | 
			
		||||
    void ConvertPipelineColorTargetEx(vk::Pipeline& pipeline, VkRenderPass renderpass,
 | 
			
		||||
                                      vk::ShaderModule& module, bool single_texture);
 | 
			
		||||
 | 
			
		||||
 
 | 
			
		||||
@@ -797,9 +797,9 @@ VkBuffer TextureCacheRuntime::GetTemporaryBuffer(size_t needed_size) {
 | 
			
		||||
        return *buffers[level];
 | 
			
		||||
    }
 | 
			
		||||
    const auto new_size = Common::NextPow2(needed_size);
 | 
			
		||||
    static constexpr VkBufferUsageFlags flags =
 | 
			
		||||
        VK_BUFFER_USAGE_TRANSFER_SRC_BIT | VK_BUFFER_USAGE_TRANSFER_DST_BIT |
 | 
			
		||||
        VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT;
 | 
			
		||||
    VkBufferUsageFlags flags = VK_BUFFER_USAGE_TRANSFER_SRC_BIT | VK_BUFFER_USAGE_TRANSFER_DST_BIT |
 | 
			
		||||
                               VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT |
 | 
			
		||||
                               VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT;
 | 
			
		||||
    buffers[level] = device.GetLogical().CreateBuffer({
 | 
			
		||||
        .sType = VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO,
 | 
			
		||||
        .pNext = nullptr,
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user