mirror of
				https://git.suyu.dev/suyu/suyu
				synced 2025-11-04 00:49:02 -06:00 
			
		
		
		
	shader: Make IMNMX, SHR, SEL stylistically more consistent
This commit is contained in:
		@@ -23,7 +23,7 @@ void IMNMX(TranslatorVisitor& v, u64 insn, const IR::U32& op_b) {
 | 
			
		||||
        throw NotImplementedException("IMNMX.MODE");
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    IR::U1 pred = v.ir.GetPred(imnmx.pred);
 | 
			
		||||
    IR::U1 pred{v.ir.GetPred(imnmx.pred)};
 | 
			
		||||
    const IR::U32 op_a{v.X(imnmx.src_reg)};
 | 
			
		||||
    IR::U32 min;
 | 
			
		||||
    IR::U32 max;
 | 
			
		||||
 
 | 
			
		||||
@@ -16,7 +16,7 @@ void SHR(TranslatorVisitor& v, u64 insn, const IR::U32& shift) {
 | 
			
		||||
        BitField<39, 1, u64> is_wrapped;
 | 
			
		||||
        BitField<40, 1, u64> brev;
 | 
			
		||||
        BitField<43, 1, u64> xmode;
 | 
			
		||||
        BitField<48, 1, u64> is_arithmetic;
 | 
			
		||||
        BitField<48, 1, u64> is_signed;
 | 
			
		||||
    } const shr{insn};
 | 
			
		||||
 | 
			
		||||
    if (shr.xmode != 0) {
 | 
			
		||||
@@ -29,7 +29,7 @@ void SHR(TranslatorVisitor& v, u64 insn, const IR::U32& shift) {
 | 
			
		||||
    }
 | 
			
		||||
    IR::U32 result;
 | 
			
		||||
    const IR::U32 safe_shift = shr.is_wrapped == 0 ? shift : v.ir.BitwiseAnd(shift, v.ir.Imm32(31));
 | 
			
		||||
    if (shr.is_arithmetic == 1) {
 | 
			
		||||
    if (shr.is_signed == 1) {
 | 
			
		||||
        result = IR::U32{v.ir.ShiftRightArithmetic(base, safe_shift)};
 | 
			
		||||
    } else {
 | 
			
		||||
        result = IR::U32{v.ir.ShiftRightLogical(base, safe_shift)};
 | 
			
		||||
 
 | 
			
		||||
@@ -13,13 +13,13 @@ void SEL(TranslatorVisitor& v, u64 insn, const IR::U32& src) {
 | 
			
		||||
    union {
 | 
			
		||||
        u64 raw;
 | 
			
		||||
        BitField<0, 8, IR::Reg> dest_reg;
 | 
			
		||||
        BitField<8, 8, IR::Reg> op_a;
 | 
			
		||||
        BitField<8, 8, IR::Reg> src_reg;
 | 
			
		||||
        BitField<39, 3, IR::Pred> pred;
 | 
			
		||||
        BitField<42, 1, u64> neg_pred;
 | 
			
		||||
    } const sel{insn};
 | 
			
		||||
 | 
			
		||||
    const IR::U1 pred = v.ir.GetPred(sel.pred);
 | 
			
		||||
    IR::U32 op_a{v.X(sel.op_a)};
 | 
			
		||||
    IR::U32 op_a{v.X(sel.src_reg)};
 | 
			
		||||
    IR::U32 op_b{src};
 | 
			
		||||
    if (sel.neg_pred != 0) {
 | 
			
		||||
        std::swap(op_a, op_b);
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user